Skip to content

fix(review): record work acceptance evidence as structured metadata, not in PR description - #5579

Merged
purp merged 1 commit into
ai-openshell:mainfrom
purp:fix/5577-acceptance-evidence/purp
Nov 16, 2026
Merged

purp merged 1 commit into
ai-openshell:mainfrom
purp:fix/5577-acceptance-evidence/purp

Conversation

@purp

@purp purp commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Record the basis for automatic PR acceptance as structured metadata on the label event, and stop instructing authors to put acceptance evidence in PR descriptions.

Related Issue

Closes #5577

Changes

  • Store versioned JSON in the state:accepted label event rationale, identifying the qualifying maintainer, repository permission, or accepted issue relationship.
  • Preserve the existing acceptance criteria and additive labeling behavior.
  • Update contributor guidance to keep administrative acceptance details out of the PR description.

Release Notes

Testing

  • Acceptance, review-readiness, and issue-labeling unit tests (264 tests)
  • Ruff check and format check; git diff --check
  • E2E tests added/updated (not applicable)

The broad local pre-commit hook was bypassed after it previously timed out during repository-wide Rust lint; the focused checks above passed.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@purp
purp requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners November 14, 2026 23:11
@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 14, 2026
@purp purp changed the title fix(review): record structured acceptance evidence fix(review): record work acceptance evidence as structured metadata, not in PR description Nov 15, 2026
@purp purp added area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. topic:dx Making OpenShell easy to contribute to for humans and agents. labels Nov 15, 2026
@purp
purp added this pull request to the merge queue Nov 16, 2026
Merged via the queue into ai-openshell:main with commit d85ff58 Nov 16, 2026
98 of 99 checks passed
@purp
purp deleted the fix/5577-acceptance-evidence/purp branch November 16, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. state:accepted A maintainer decided OpenShell should pursue this issue topic:dx Making OpenShell easy to contribute to for humans and agents.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(review): record structured acceptance evidence without PR body notes

2 participants