Skip to content

fix(cli): show full date in rule history - #5576

Merged
johntmyers merged 1 commit into
ai-openshell:mainfrom
ericcurtin:fix/5556-rule-history-timestamp/ericcurtin
Nov 16, 2026
Merged

johntmyers merged 1 commit into
ai-openshell:mainfrom
ericcurtin:fix/5556-rule-history-timestamp/ericcurtin

Conversation

@ericcurtin

Copy link
Copy Markdown
Contributor

Summary

rule history now prints YYYY-MM-DD HH:MM:SS like the other commands.

Related Issue

Closes #5556

Changes

  • Use format_optional_epoch_ms for history entries.
  • Remove the unused format_timestamp_ms.

Release Notes

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 14, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@TaylorMutch @krishicks PTAL when you get a chance, and could you please triage #5556 so the issue check can pass? /ok to test 9437349d769e8aa540c7be3c3057bc28e3400765 if it looks good. Thank you!

@johntmyers

Copy link
Copy Markdown
Contributor

/ok to test 9437349

@johntmyers johntmyers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gator-agent

PR Review Status

The independent review found no blocking code findings or security regressions. The change reuses the existing UTC date formatter and preserves - for missing timestamps; the added unit test covers a dated value and zero. Tests were not run locally.

Thanks @ericcurtin, I checked your request to triage #5556 and start CI. The issue is now accepted, and I posted /ok to test for the current head. Branch Checks and Trivy are running, and Helm Lint passed. The acceptance-check rerun failed at startup before creating any jobs, so this is a CI process blocker rather than an author code finding.

Action required: A maintainer should investigate and restart PR Issue Acceptance; @ericcurtin should add a small Fern docs update for the changed history output, or a maintainer should explain why documentation is intentionally unnecessary.

Blocking code findings: None.
Carried findings: None.

Gator metadata
  • Validation: Focused CLI bug fix for accepted issue #5556.
  • Docs: Direct CLI output change; no docs update or maintainer exemption in the existing PR discussion. Published docs do not assert a conflicting timestamp format.
  • Checks: DCO and vouch passed; current-head Branch Checks running; Helm Lint passed; PR Issue Acceptance rerun ended in startup_failure with no jobs.
  • E2E: Not required for this display-only formatter change; no sandbox lifecycle, policy, provider, driver, GPU, Kubernetes, or Windows behavior changes. No test labels applied.
  • Head SHA: 9437349d769e8aa540c7be3c3057bc28e3400765
  • Base SHA: 2e5589b2180dd432320adda124c4f7bcede119b5
  • Merge base SHA: 2e5589b2180dd432320adda124c4f7bcede119b5
  • Patch ID: 3cd436df754d72461848f64e752766e0af98dd5f
  • Gator payload: 13
  • Review mode: initial
  • Previous reviewed SHA: none
  • Review budget exhausted: no
  • Maintainer decision required: yes — CI startup failure and documentation disposition.
  • Next state: gator:blocked
  • Blocked reason: required_workflow_startup_failure

@johntmyers johntmyers added the gator:blocked Gator is blocked by process or repository gates label Nov 16, 2026
@johntmyers

Copy link
Copy Markdown
Contributor

gator-agent

PR Review Status

The independent review found no blocking code findings or security regressions. The change reuses the existing UTC date formatter and preserves - for missing timestamps; the added unit test covers a dated value and zero. Tests were not run locally.

Thanks @ericcurtin, I checked your request to triage #5556 and start CI. The issue is now accepted, and I posted /ok to test for the current head. Branch Checks and Trivy are running, and Helm Lint passed. The acceptance-check rerun failed at startup before creating any jobs, so this is a CI process blocker rather than an author code finding.

Action required: A maintainer should investigate and restart PR Issue Acceptance; @ericcurtin should add a small Fern docs update for the changed history output, or a maintainer should explain why documentation is intentionally unnecessary.

Blocking code findings: None. Carried findings: None.

Gator metadata

We can waive docs updates.

@johntmyers johntmyers added gator:approval-needed Gator completed review; maintainer approval needed and removed gator:blocked Gator is blocked by process or repository gates labels Nov 16, 2026
@ericcurtin

Copy link
Copy Markdown
Contributor Author

No docs show the rule history timestamp format, so no docs change is needed.

@johntmyers
johntmyers enabled auto-merge November 16, 2026 23:32
@johntmyers johntmyers added gator:watch-pipeline Gator is monitoring PR CI/CD status and removed gator:approval-needed Gator completed review; maintainer approval needed labels Nov 16, 2026
@johntmyers
johntmyers added this pull request to the merge queue Nov 16, 2026
@johntmyers johntmyers added gator:merge-ready and removed gator:watch-pipeline Gator is monitoring PR CI/CD status labels Nov 16, 2026
Merged via the queue into ai-openshell:main with commit b0c831b Nov 16, 2026
103 of 108 checks passed
@johntmyers

Copy link
Copy Markdown
Contributor

gator-agent

Monitoring Complete

Monitoring is complete because this PR has merged.

Final status: The current head received a Gator review with no blocking code findings and maintainer approval. The last Gator state was gator:merge-ready.

I removed the active gator:* label because there is nothing left for gator to monitor on this PR.

Gator metadata
  • Head SHA: 9437349d769e8aa540c7be3c3057bc28e3400765
  • Gator payload: 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(cli): openshell rule history shows timestamps as "20770d 15:54"

2 participants