Repository navigation
fix(cli): show full date in rule history - #5576
johntmyers merged 1 commit into
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
@TaylorMutch @krishicks PTAL when you get a chance, and could you please triage #5556 so the issue check can pass? |
|
/ok to test 9437349 |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
The independent review found no blocking code findings or security regressions. The change reuses the existing UTC date formatter and preserves - for missing timestamps; the added unit test covers a dated value and zero. Tests were not run locally.
Thanks @ericcurtin, I checked your request to triage #5556 and start CI. The issue is now accepted, and I posted /ok to test for the current head. Branch Checks and Trivy are running, and Helm Lint passed. The acceptance-check rerun failed at startup before creating any jobs, so this is a CI process blocker rather than an author code finding.
Action required: A maintainer should investigate and restart PR Issue Acceptance; @ericcurtin should add a small Fern docs update for the changed history output, or a maintainer should explain why documentation is intentionally unnecessary.
Blocking code findings: None.
Carried findings: None.
Gator metadata
- Validation: Focused CLI bug fix for accepted issue #5556.
- Docs: Direct CLI output change; no docs update or maintainer exemption in the existing PR discussion. Published docs do not assert a conflicting timestamp format.
- Checks: DCO and vouch passed; current-head Branch Checks running; Helm Lint passed; PR Issue Acceptance rerun ended in startup_failure with no jobs.
- E2E: Not required for this display-only formatter change; no sandbox lifecycle, policy, provider, driver, GPU, Kubernetes, or Windows behavior changes. No test labels applied.
- Head SHA:
9437349d769e8aa540c7be3c3057bc28e3400765 - Base SHA:
2e5589b2180dd432320adda124c4f7bcede119b5 - Merge base SHA:
2e5589b2180dd432320adda124c4f7bcede119b5 - Patch ID:
3cd436df754d72461848f64e752766e0af98dd5f - Gator payload:
13 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: yes — CI startup failure and documentation disposition.
- Next state:
gator:blocked - Blocked reason:
required_workflow_startup_failure
We can waive docs updates. |
|
No docs show the rule history timestamp format, so no docs change is needed. |
b0c831b
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: The current head received a Gator review with no blocking code findings and maintainer approval. The last Gator state was I removed the active Gator metadata
|
Summary
rule historynow printsYYYY-MM-DD HH:MM:SSlike the other commands.Related Issue
Closes #5556
Changes
format_optional_epoch_msfor history entries.format_timestamp_ms.Release Notes
Testing
Checklist