Skip to content

fix(review): accept language-only SDK classifications - #5516

Merged
purp merged 1 commit into
ai-openshell:mainfrom
purp:fix/5515-sdk-language-classification/purp
Nov 12, 2026
Merged

purp merged 1 commit into
ai-openshell:mainfrom
purp:fix/5515-sdk-language-classification/purp

Conversation

@purp

@purp purp commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Accept SDK language topics without requiring the removed topic:sdk category.

Related Issue

Closes #5515. Preparation for #5151.

Changes

  • Remove the parent-topic requirement from validation and the labeling skill.
  • Verify a language-only SDK classification against a roster without topic:sdk.

Release Notes

Testing

  • 80 policy and reconciliation tests pass.
  • Regression test updated.
  • Ruff lint, format checks, and git diff --check pass.

Checklist

  • Follows Conventional Commits.
  • Commits are signed off (DCO).

Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 12, 2026
@purp
purp marked this pull request as ready for review November 12, 2026 13:32
@purp
purp enabled auto-merge November 12, 2026 13:34
@purp purp added the area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. label Nov 12, 2026
@purp
purp added this pull request to the merge queue Nov 12, 2026
Merged via the queue into ai-openshell:main with commit 8606ee3 Nov 12, 2026
97 checks passed
@purp
purp deleted the fix/5515-sdk-language-classification/purp branch November 12, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. state:accepted A maintainer decided OpenShell should pursue this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(review): accept language-only SDK classifications

2 participants