Repository navigation
Conversation
6 tasks
github-actions
Bot
requested review from
FrostGod,
drew,
mrunalp and
russellb
November 11, 2026 15:42
elezar
force-pushed
the
refactor/5456-driver-contract-types/elezar
branch
from
November 12, 2026 12:38
d830485 to
af28bc2
Compare
elezar
force-pushed
the
refactor/5456-driver-contract-types/elezar
branch
from
November 12, 2026 12:50
af28bc2 to
bc41cbe
Compare
This was referenced Nov 12, 2026
elezar
force-pushed
the
refactor/5456-driver-contract-types/elezar
branch
from
November 13, 2026 12:52
bc41cbe to
a1e935f
Compare
elezar
force-pushed
the
refactor/5456-driver-contract-types/elezar
branch
from
November 13, 2026 13:07
a1e935f to
f96b308
Compare
This was referenced Nov 14, 2026
Docker, Podman, and the VM driver hand the supervisor and the sandbox boundary a set of JSON documents whose only definition is Rust types in openshell-sandbox-backend and openshell-isolation-interface, which pull in openshell-core. Move those types into an openshell-driver-sdk module behind the legacy-contract feature, re-export them from their old paths, and repoint the three drivers. The module is documented as legacy: it describes the format that exists today, accepts no new fields, and is removed once a replacement ships. Golden JSON examples and a round-trip test pin the encoding. The drivers no longer depend on openshell-core, openshell-sandbox-backend, openshell-isolation-interface, or openshell-policy for normal builds. Signed-off-by: Evan Lezar <elezar@nvidia.com>
…ract crate
Docker, Podman, and the VM driver hand the supervisor and the sandbox
boundary a set of documents whose only definition is Rust types. Move the
types out of openshell-driver-sdk into a new openshell-driver-contract crate
that the driver, the supervisor, and the sandbox boundary all depend on
without depending on each other.
The crate has three modules: model (the types, no I/O), write (the driver
side, behind the write feature so that readers do not build the certificate
generation code), and read (the supervisor and sandbox side). The SDK
re-exports the crate as driver_contract and keeps sandbox_session,
jwt::{CredentialEpoch, SessionRotation}, and paths::is_posix_absolute
resolving. The legacy-contract feature is removed and the jwt feature is no
longer forced on. The JWT launch documents stay in the SDK with their own
test and examples.
openshell_sandbox_backend::boundary_protocol and
openshell_isolation_interface::contract remain as re-exports for code
outside this repository. generate_sandbox_tls_material is re-exported from
boundary_protocol only with the sandbox-backend write feature.
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
refactor/5456-driver-contract-types/elezar
branch
from
November 16, 2026 15:29
03442f8 to
9f7d983
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the driver contract types (the documents a compute driver hands to the supervisor and the sandbox boundary) out of
openshell-driver-sdkinto a newopenshell-driver-contractcrate, so the driver, the supervisor and the sandbox boundary depend on it without depending on each other.Related Issue
Part of #5456. Stacked on #5405.
Changes
model(types, no I/O),write(driver side, behind thewritefeature so readers do not build the certificate generation code) andread(supervisor and sandbox side).driver_contractand keepssandbox_session,jwt::{CredentialEpoch, SessionRotation}andpaths::is_posix_absoluteresolving. Thelegacy-contractfeature is removed andjwtis no longer forced on. The JWT launch documents stay in the SDK.openshell_sandbox_backend::boundary_protocolandopenshell_isolation_interface::contractremain as re-exports for code outside this repository.Release Notes
None.
Testing
rust:deny:policy,buf lintandbuf breakingpass at this tip. Theopenshell-driver-vmtests were not run to completion: they needmke2fs, which was unavailable locally.Checklist