Skip to content

fix(cli): accept allow-encoded-slash in policy update - #4968

Merged
pimlock merged 1 commit into
ai-openshell:mainfrom
ericcurtin:fix/4926-add-endpoint-encoded-slash/ericcurtin
Nov 8, 2026
Merged

pimlock merged 1 commit into
ai-openshell:mainfrom
ericcurtin:fix/4926-add-endpoint-encoded-slash/ericcurtin

Conversation

@ericcurtin

@ericcurtin ericcurtin commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds allow-encoded-slash to the policy update --add-endpoint options, so the fix the %2F denial recommends can be applied incrementally.

Related Issue

Fixes #4926

Changes

  • Parse allow-encoded-slash (needs a rest or websocket endpoint).
  • Merge the two protocol check helpers into one.
  • Update the option list in the help text, the error message, and the network rules docs.

Release Notes

openshell policy update --add-endpoint now accepts the allow-encoded-slash option.

Testing

  • Checks appropriate to the affected code and behavior pass (cargo fmt --check, cargo clippy -p openshell-cli --tests, cargo test -p openshell-cli --lib policy_update)
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Also merge the two protocol check helpers into one.

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@ericcurtin

Copy link
Copy Markdown
Contributor Author

@TaylorMutch @SDAChess could you please triage #4926 so the issue check can pass? PTAL, and /ok to test 2f4ffa6e088f5c76edddc7ca153947246186bc99 if it looks good. Thank you!

@copy-pr-bot

copy-pr-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@shailendra-nv @krishicks could you please triage #4926 so the issue check can pass? PTAL, and /ok to test 2f4ffa6e088f5c76edddc7ca153947246186bc99 if it looks good. Thank you!

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@johntmyers @pimlock PTAL when you get a chance, and could one of you triage #4926 so the issue check can pass? /ok to test 2f4ffa6e088f5c76edddc7ca153947246186bc99 if it looks good. Thank you!

@pimlock

pimlock commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

/ok to test 2f4ffa6

@pimlock
pimlock added this pull request to the merge queue Nov 8, 2026
Merged via the queue into ai-openshell:main with commit af02016 Nov 8, 2026
82 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(cli): policy update --add-endpoint rejects allow_encoded_slash, the same option its denial message tells users to set

2 participants