From da77143d240c3cc71ed37aa0235341ce7d1f92da Mon Sep 17 00:00:00 2001 From: Matt Humphrey Date: Fri, 2 Nov 2012 14:37:22 +0000 Subject: [PATCH] Add default error message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Github also throws `custom` error messages and the switch doesn't catch it. ```[errors] => Array         (             [0] => Array                 (                     [code] => custom                     [resource] => Repository                     [field] => name                     [message] => name can't be private. You are over your quota.                 )         )``` Adding a `default` fixes this. --- lib/Github/HttpClient/Listener/ErrorListener.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/Github/HttpClient/Listener/ErrorListener.php b/lib/Github/HttpClient/Listener/ErrorListener.php index 49b144883cb..1d537240900 100644 --- a/lib/Github/HttpClient/Listener/ErrorListener.php +++ b/lib/Github/HttpClient/Listener/ErrorListener.php @@ -71,10 +71,14 @@ public function postSend(RequestInterface $request, MessageInterface $response) $errors[] = sprintf('Field "%s" already exists, for resource "%s"', $error['field'], $error['resource']); break; + default: + $errors[] = $error['message']; + break; + } } - throw new ValidationFailedException('Validation Failed:' . implode(', ', $errors), 422); + throw new ValidationFailedException('Validation Failed: ' . implode(', ', $errors), 422); } }