Skip to content

GPU: Unify usage of half precision float into half_t typedef in GPUCommonMath.h - #16149

Open
davidrohr wants to merge 2 commits into
AliceO2Group:devfrom
davidrohr:PR
Open

davidrohr wants to merge 2 commits into
AliceO2Group:devfrom
davidrohr:PR

Conversation

@davidrohr

Copy link
Copy Markdown
Collaborator

@ChSonnabend : Could you check if that works correctly for your ONNXRuntime code?

@davidrohr
davidrohr requested review from a team and sgorbuno as code owners November 18, 2026 10:41
@davidrohr

Copy link
Copy Markdown
Collaborator Author

@ktf : Could you check the metal changes?

if (IsNegative()) {
return -o.f;
}
#elif __cplusplus >= 202302L && defined(__STDCPP_FLOAT16_T__)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#elif __cplusplus >= 202302L && defined(__STDCPP_FLOAT16_T__)
#if __cplusplus >= 202302L && defined(__STDCPP_FLOAT16_T__)

no?

@ktf

ktf commented Nov 18, 2026

Copy link
Copy Markdown
Member

Apart from the inline comment, everything else is bit-to-bit compatible on metal.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants